Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the obsolete exec_tools attribute from genrule. #19142

Closed
wants to merge 1 commit into from
Closed

Remove the obsolete exec_tools attribute from genrule. #19142

wants to merge 1 commit into from

Conversation

katre
Copy link
Member

@katre katre commented Aug 1, 2023 •
edited
Loading

Part of #19132.

@katre katre mentioned this pull request Aug 1, 2023
Closed
@katre katre changed the title [WIP] [DNS] Remove the obsolete exec_tools attribute from genrule. Remove the obsolete exec_tools attribute from genrule. Aug 4, 2023
@katre katre requested a review from meteorcloudy August 4, 2023 17:07
@katre katre marked this pull request as ready for review August 4, 2023 17:07
@katre
Copy link
Member Author

katre commented Aug 4, 2023

Downstream tests are clean: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3215
Failures are unrelated to this change.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 4, 2023
@sgowroji sgowroji added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Aug 7, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 7, 2023
@copybara-service copybara-service bot closed this in 5ce12ee Aug 7, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 7, 2023
@katre katre deleted the remove-exec-tools branch August 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katre @meteorcloudy @sgowroji